Skip to content

Conversation

@oleksii-novikov-onix
Copy link
Contributor

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@oleksii-novikov-onix oleksii-novikov-onix force-pushed the FINERACT-2413/manual-reamortization-undo branch 2 times, most recently from b95f5bb to db8289d Compare December 18, 2025 15:32
@adamsaghy
Copy link
Contributor

Failed scenarios:
  file:///home/runner/work/fineract/fineract/fineract-e2e-tests-runner/src/test/resources/features/LoanReAmortization.feature:597 # Verify Loan re-amortization transaction reverse-replay - UC5: re-amortization validation should not consider reverted transactions
  
  37 Scenarios (1 failed, 36 passed)
  679 Steps (1 failed, 3 skipped, 675 passed)
  3m50.818s
  
  
  org.apache.fineract.client.feign.util.CallFailedRuntimeException: HTTP failed: status=403, request=https://localhost:8443/fineract-provider/api/v1/loans/158/transactions?command=undoReAmortize, errorBody={"developerMessage":"Request was understood but caused a domain rule violation.","httpStatusCode":"403","defaultUserMessage":"Errors contain reason for domain rule violation.","userMessageGlobalisationCode":"validation.msg.domain.rule.violation","errors":[{"defaultUserMessage":"Undoing a reamortization can only be done if there hasn't been any monetary transaction afterwards","parameterName":"id","developerMessage":"Undoing a reamortization can only be done if there hasn't been any monetary transaction afterwards","userMessageGlobalisationCode":"error.msg.loan.reamortize.repayment.exists.after.reamortization","args":[{"value":158}]}]}
  	at org.apache.fineract.client.feign.util.FeignCalls.ok(FeignCalls.java:46)
  	at org.apache.fineract.test.stepdef.loan.LoanReAmortizationStepDef.undoLoanReAmortization(LoanReAmortizationStepDef.java:101)
  	at ✽.Admin undo Loan re-amortization transaction on current business date(file:///home/runner/work/fineract/fineract/fineract-e2e-tests-runner/src/test/resources/features/LoanReAmortization.feature:676)
  Caused by: org.apache.fineract.client.feign.FeignException: status 403 (Validation errors: [id] Undoing a reamortization can only be done if there hasn't been any monetary transaction afterwards)

@oleksii-novikov-onix oleksii-novikov-onix force-pushed the FINERACT-2413/manual-reamortization-undo branch from db8289d to 5170f4b Compare December 19, 2025 11:08
@MarianaDmytrivBinariks MarianaDmytrivBinariks force-pushed the FINERACT-2413/manual-reamortization-undo branch from 8153396 to e87f102 Compare December 19, 2025 16:39
@oleksii-novikov-onix oleksii-novikov-onix force-pushed the FINERACT-2413/manual-reamortization-undo branch from e87f102 to 7cb7f81 Compare December 19, 2025 19:25
@oleksii-novikov-onix oleksii-novikov-onix marked this pull request as ready for review December 19, 2025 21:27
@galovics galovics merged commit 46f218f into apache:develop Dec 23, 2025
34 checks passed
@galovics galovics deleted the FINERACT-2413/manual-reamortization-undo branch December 23, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants